Skip to content

XPath: implement lang() and id() core functions #52891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 2, 2025
Merged

XPath: implement lang() and id() core functions #52891

merged 3 commits into from
Jun 2, 2025

Conversation

servo-wpt-sync
Copy link
Collaborator

@servo-wpt-sync servo-wpt-sync commented Jun 1, 2025 •
edited
Loading

XPath's lang() and id() functions were still unimplemented.

Also:

  • Add WPT tests for id().
  • Fix uniqueness check in NodesetHelpers::document_order_unique.
  • Tweak the AST a bit to make it clearer to express "no predicates".
  • Fix a parsing bug where "/" was attempted before "//", leaving the "//" branch as always unused.

Reviewed in servo/servo#34594

@servo-wpt-sync servo-wpt-sync mentioned this pull request Jun 1, 2025
Merged
4 tasks
wpt-pr-bot
wpt-pr-bot approved these changes Jun 1, 2025
View reviewed changes
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Servo project.

@servo-wpt-sync servo-wpt-sync force-pushed the servo_export_34594 branch 4 times, most recently from 68e7140 to f302dab Compare June 2, 2025 07:09
vlindhol added 3 commits June 2, 2025 08:44
@vlindhol @servo-wpt-sync
add xpath id() function tests
e887483 
Signed-off-by: Ville Lindholm <ville@lindholm.dev>
@vlindhol @servo-wpt-sync
Lint WPT test
5b2a8c9 
Signed-off-by: Ville Lindholm <ville@lindholm.dev>
@vlindhol @servo-wpt-sync
PR review 2
1fcbc2f 
Signed-off-by: Ville Lindholm <ville@lindholm.dev>
@servo-wpt-sync servo-wpt-sync merged commit 1329b91 into web-platform-tests:master Jun 2, 2025
19 checks passed
@servo-wpt-sync servo-wpt-sync deleted the servo_export_34594 branch June 2, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpt-pr-bot wpt-pr-bot wpt-pr-bot approved these changes

Assignees
No one assigned
Labels
domxpath servo-export wg-dom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@servo-wpt-sync @wpt-pr-bot @vlindhol